mirrors/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity.git synced 2025-01-24 10:22:05 -05:00
Code Issues Projects Releases Packages Wiki Activity

LibWeb: Invalidate less style on textContent change and node removal

Browse source 
...unless there are :has() selectors present. Then we have to invalidate
everything for now.

(cherry picked from commit b8ce34068f5bf8ab8cf049d56b864bff52ef3dff)
This commit is contained in:
Andreas Kling 2024-09-22 13:27:46 +02:00 • committed by Nico Weber
parent a49ba1914a
commit 88b2d705e2
1 changed files with 15 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
Userland/Libraries/LibWeb/DOM/Node.cpp
View file

@ -207,7 +207,13 @@ void Node::set_text_content(Optional<String> const& maybe_content)
// Otherwise, do nothing.
if (is_connected()) {
document().invalidate_style(StyleInvalidationReason::NodeSetTextContent);
// FIXME: If there are any :has() selectors, we currently invalidate style for the whole document.
// We need to find a way to invalidate less!
if (document().style_computer().has_has_selectors()) {
document().invalidate_style(StyleInvalidationReason::NodeSetTextContent);
} else {
invalidate_style(StyleInvalidationReason::NodeSetTextContent);
}
document().invalidate_layout_tree();
}
@ -882,7 +888,14 @@ void Node::remove(bool suppress_observers)
if (was_connected) {
// Since the tree structure has changed, we need to invalidate both style and layout.
// In the future, we should find a way to only invalidate the parts that actually need it.
document().invalidate_style(StyleInvalidationReason::NodeRemove);
// FIXME: If there are any :has() selectors, we currently invalidate style for the whole document.
// We need to find a way to invalidate less!
if (document().style_computer().has_has_selectors()) {
document().invalidate_style(StyleInvalidationReason::NodeRemove);
} else {
invalidate_style(StyleInvalidationReason::NodeRemove);
}
// NOTE: If we didn't have a layout node before, rebuilding the layout tree isn't gonna give us one
// after we've been removed from the DOM.