mirrors/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity.git synced 2025-01-24 10:22:05 -05:00
Code Issues Projects Releases Packages Wiki Activity

WindowServer: Call screen_resolution_changed after window screens clear

Browse source 
When the user executes chres to change to a new resolution, the
WindowManager removes for each window its intersections with the
screens (window.screens()) and recalculates its rect. Finally, a
Window::set_rect call sets the window's new rectangle. The set_rect
call also triggers a call to Compositor::invalidate_occlusions which
fills for each window the intersections with the screens again in
window.screens().
In case chres switches to an already present resolution the set_rect
call exits prematurely as it checks if the window's rect really
changed. This means that nobody calls invalidate_occlusions
resulting in a rendering issue for each window.

Moving the call to Compositor::screen_resolution_changed after the
clearing of window.screens() and recalc of the window rect for each
window resolves the rendering issue as screen_resolution_changed
calls invalidate_occlusions.
This commit is contained in:
montiagne 2022-05-28 20:14:44 +00:00 • committed by Linus Groh
parent 4fcdbd57e9
commit 9e694c9d83
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
Userland/Services/WindowServer/WindowManager.cpp
View file

@ -116,8 +116,6 @@ bool WindowManager::set_screen_layout(ScreenLayout&& screen_layout, bool save, S
reload_icon_bitmaps_after_scale_change();
Compositor::the().screen_resolution_changed();
tell_wms_screen_rects_changed();
for_each_window_stack([&](auto& window_stack) {
@ -129,6 +127,8 @@ bool WindowManager::set_screen_layout(ScreenLayout&& screen_layout, bool save, S
return IterationDecision::Continue;
});
Compositor::the().screen_resolution_changed();
if (save)
Screen::layout().save_config(*m_config);
return true;