mirrors/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity.git synced 2025-01-22 09:21:57 -05:00
Code Issues Projects Releases Packages Wiki Activity

AK: Fix {:c} formatter for big-endian

Browse source
This commit is contained in:
Dennis Camera 2024-07-04 11:18:36 +02:00 committed by Tim Schumacher
parent 0b54579173
commit b367479d00
1 changed files with 8 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
AK/Format.cpp
View file

@ -879,13 +879,17 @@ template<Integral T>
ErrorOr<void> Formatter<T>::format(FormatBuilder& builder, T value) ErrorOr<void> Formatter<T>::format(FormatBuilder& builder, T value)
{ {
if (m_mode == Mode::Character) { if (m_mode == Mode::Character) {
// FIXME: We just support ASCII for now, in the future maybe unicode?
// VERIFY(value >= 0 && value <= 127);
m_mode = Mode::String; m_mode = Mode::String;
Formatter<StringView> formatter { *this }; Formatter<StringView> formatter { *this };
return formatter.format(builder, StringView { reinterpret_cast<char const*>(&value), 1 });
// FIXME: We just support ASCII for now, in the future maybe unicode?
VERIFY(value >= 0 && value <= 127);
// Convert value to a single byte. This is important for big-endian systems, because the LSB is stored in the last byte.
char const c = (value & 0x7f);
return formatter.format(builder, StringView { &c, 1 });
} }
if (m_precision.has_value()) if (m_precision.has_value())