mirror of
https://github.com/SerenityOS/serenity.git
synced 2025-01-23 01:41:59 -05:00
Kernel: Support Mutex Protected lists in ListedRefCounted
This will allow us to support Mutex Protected lists like the custodies list as well.
This commit is contained in:
parent
7204b292c5
commit
be91b4fe3e
4 changed files with 19 additions and 8 deletions
|
@ -23,7 +23,7 @@
|
|||
|
||||
namespace Kernel {
|
||||
|
||||
class Inode : public ListedRefCounted<Inode>
|
||||
class Inode : public ListedRefCounted<Inode, LockType::Spinlock>
|
||||
, public Weakable<Inode> {
|
||||
friend class VirtualFileSystem;
|
||||
friend class FileSystem;
|
||||
|
|
|
@ -11,21 +11,32 @@
|
|||
namespace Kernel {
|
||||
|
||||
// ListedRefCounted<T> is a slot-in replacement for RefCounted<T> to use in classes
|
||||
// that add themselves to a SpinlockProtected<IntrusiveList> when constructed.
|
||||
// The custom unref() implementation here ensures that the the list is locked during
|
||||
// that add themselves to a {Spinlock, Mutex}Protected<IntrusiveList> when constructed.
|
||||
// The custom unref() implementation here ensures that the list is locked during
|
||||
// unref(), and that the T is removed from the list before ~T() is invoked.
|
||||
|
||||
template<typename T>
|
||||
enum class LockType {
|
||||
Spinlock,
|
||||
Mutex,
|
||||
};
|
||||
|
||||
template<typename T, LockType Lock>
|
||||
class ListedRefCounted : public RefCountedBase {
|
||||
public:
|
||||
bool unref() const
|
||||
{
|
||||
auto new_ref_count = T::all_instances().with([&](auto& list) {
|
||||
auto callback = [&](auto& list) {
|
||||
auto new_ref_count = deref_base();
|
||||
if (new_ref_count == 0)
|
||||
list.remove(const_cast<T&>(static_cast<T const&>(*this)));
|
||||
return new_ref_count;
|
||||
});
|
||||
};
|
||||
|
||||
RefCountType new_ref_count;
|
||||
if constexpr (Lock == LockType::Spinlock)
|
||||
new_ref_count = T::all_instances().with(callback);
|
||||
else if constexpr (Lock == LockType::Mutex)
|
||||
new_ref_count = T::all_instances().with_exclusive(callback);
|
||||
if (new_ref_count == 0) {
|
||||
call_will_be_destroyed_if_present(static_cast<const T*>(this));
|
||||
delete const_cast<T*>(static_cast<T const*>(this));
|
||||
|
|
|
@ -18,7 +18,7 @@
|
|||
namespace Kernel::Memory {
|
||||
|
||||
class VMObject
|
||||
: public ListedRefCounted<VMObject>
|
||||
: public ListedRefCounted<VMObject, LockType::Spinlock>
|
||||
, public Weakable<VMObject> {
|
||||
friend class MemoryManager;
|
||||
friend class Region;
|
||||
|
|
|
@ -146,7 +146,7 @@ struct ThreadRegisters {
|
|||
};
|
||||
|
||||
class Thread
|
||||
: public ListedRefCounted<Thread>
|
||||
: public ListedRefCounted<Thread, LockType::Spinlock>
|
||||
, public Weakable<Thread> {
|
||||
AK_MAKE_NONCOPYABLE(Thread);
|
||||
AK_MAKE_NONMOVABLE(Thread);
|
||||
|
|
Loading…
Reference in a new issue