mirrors/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity.git synced 2025-01-22 09:21:57 -05:00
Code Issues Projects Releases Packages Wiki Activity

LibPDF: Check DecodeParms array element type before casting

Browse source 
0000337.pdf contains:

    /DecodeParms[(null)<</K -1/Columns 2545>>]

where the array's first entry `(null)` is a string with
the characters `"null"`. Casting the string to a dict used to crash.
Instead, treat non-dict array entries as if no decode parms were present
for the filter at that array position.

This will fix a crash for 0000337.pdf once we can decode /JPXDecode
filters.
This commit is contained in:
Nico Weber 2025-01-19 20:41:27 -05:00
parent 6a7b6444d4
commit c5aac68295
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
Userland/Libraries/LibPDF/Parser.cpp
View file

@ -452,8 +452,11 @@ PDFErrorOr<void> Parser::unfilter_stream(NonnullRefPtr<StreamObject> stream_obje
for (size_t i = 0; i < decode_parms_array->size(); ++i) {
RefPtr<DictObject> decode_parms;
auto entry = decode_parms_array->at(i);
if (entry.has<NonnullRefPtr<Object>>())
decode_parms = entry.get<NonnullRefPtr<Object>>()->cast<DictObject>();
if (entry.has<NonnullRefPtr<Object>>()) {
auto entry_object = entry.get<NonnullRefPtr<Object>>();
if (entry_object->is<DictObject>())
decode_parms = entry_object->cast<DictObject>();
}
decode_parms_vector.append(decode_parms);
}
} else {