mirrors/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity.git synced 2025-01-23 09:51:57 -05:00
Code Issues Projects Releases Packages Wiki Activity

LibWeb: Add GC finalizer for DOM::Node

Browse source 
Now that the layout tree is also GC-allocated, we can't be messing with
it from the DOM::Node destructor. Move everything to a GC finalizer
so we know it runs before the GC sweep phase.
This commit is contained in:
Andreas Kling 2022-10-20 19:30:29 +02:00
parent 07a36c8f80
commit c877eb47a2
2 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibWeb/DOM/Node.cpp
View file

@ -73,7 +73,9 @@ Node::Node(Document& document, NodeType type)
{ {
} }
Node::~Node() Node::~Node() = default;
void Node::finalize()
{ {
if (layout_node() && layout_node()->parent()) if (layout_node() && layout_node()->parent())
layout_node()->parent()->remove_child(*layout_node()); layout_node()->parent()->remove_child(*layout_node());

1
Userland/Libraries/LibWeb/DOM/Node.h
View file

@ -622,6 +622,7 @@ protected:
Node(Document&, NodeType); Node(Document&, NodeType);
virtual void visit_edges(Cell::Visitor&) override; virtual void visit_edges(Cell::Visitor&) override;
virtual void finalize() override;
JS::GCPtr<Document> m_document; JS::GCPtr<Document> m_document;
JS::GCPtr<Layout::Node> m_layout_node; JS::GCPtr<Layout::Node> m_layout_node;