mirrors/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity.git synced 2025-01-24 10:22:05 -05:00
Code Issues Projects Releases Packages Wiki Activity

LibWeb: Add a maximum redirects limit to FrameLoader

Browse source 
This prevents the browser from crashing when trying to load an infinite
redirects loop. The chosen limit is based on the fetch specification:
"If request's redirect count is twenty, return a network error."
This commit is contained in:
Idan Horowitz 2021-05-11 22:22:56 +03:00 • committed by Linus Groh
parent 84800a5b4f
commit ce86026ac6
2 changed files with 10 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
Userland/Libraries/LibWeb/Loader/FrameLoader.cpp
View file

@ -237,9 +237,16 @@ void FrameLoader::resource_did_load()
// FIXME: Also check HTTP status code before redirecting
auto location = resource()->response_headers().get("Location");
if (location.has_value()) {
if (m_redirects_count > maximum_redirects_allowed) {
m_redirects_count = 0;
load_error_page(url, "Too many redirects");
return;
}
m_redirects_count++;
load(url.complete_url(location.value()), FrameLoader::Type::Navigation);
return;
}
m_redirects_count = 0;
dbgln("I believe this content has MIME type '{}', encoding '{}'", resource()->mime_type(), resource()->encoding());

3
Userland/Libraries/LibWeb/Loader/FrameLoader.h
View file

@ -12,6 +12,8 @@
namespace Web {
constexpr size_t maximum_redirects_allowed = 20;
class FrameLoader final
: public ResourceClient {
public:
@ -41,6 +43,7 @@ private:
bool parse_document(DOM::Document&, const ByteBuffer& data);
Frame& m_frame;
size_t m_redirects_count { 0 };
};
}