mirrors/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity.git synced 2025-01-24 10:22:05 -05:00
Code Issues Projects Releases Packages Wiki Activity

Profiler: Show percentages with three decimal points

Browse source 
This is great when the percentages are very low.
This commit is contained in:
kleines Filmröllchen 2022-04-26 21:39:50 +02:00 • committed by Linus Groh
parent 19a4b820c4
commit d9decfbbf3
1 changed files with 10 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
Userland/DevTools/Profiler/main.cpp
View file

@ -222,6 +222,12 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
return min(end_of_trace, max(timestamp, start_of_trace));
};
auto const format_sample_count = [&profile](auto sample_count) {
if (profile->show_percentages())
return String::formatted("{:.3f}%", sample_count.as_float_or(0.0));
return String::formatted("{} Samples", sample_count.to_i32());
};
auto statusbar = TRY(main_widget->try_add<GUI::Statusbar>());
auto statusbar_update = [&] {
auto& view = *timeline_view;
@ -230,11 +236,11 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
auto flamegraph_hovered_index = flamegraph_view->hovered_index();
if (flamegraph_hovered_index.is_valid()) {
auto stack = profile->model().data(flamegraph_hovered_index.sibling_at_column(ProfileModel::Column::StackFrame)).to_string();
auto sample_count = profile->model().data(flamegraph_hovered_index.sibling_at_column(ProfileModel::Column::SampleCount)).to_i32();
auto self_count = profile->model().data(flamegraph_hovered_index.sibling_at_column(ProfileModel::Column::SelfCount)).to_i32();
auto sample_count = profile->model().data(flamegraph_hovered_index.sibling_at_column(ProfileModel::Column::SampleCount));
auto self_count = profile->model().data(flamegraph_hovered_index.sibling_at_column(ProfileModel::Column::SelfCount));
builder.appendff("{}, ", stack);
builder.appendff("Samples: {}{}, ", sample_count, profile->show_percentages() ? "%" : " Samples");
builder.appendff("Self: {}{}", self_count, profile->show_percentages() ? "%" : " Samples");
builder.appendff("Samples: {}, ", format_sample_count(sample_count));
builder.appendff("Self: {}", format_sample_count(self_count));
} else {
u64 normalized_start_time = clamp_timestamp(min(view.select_start_time(), view.select_end_time()));
u64 normalized_end_time = clamp_timestamp(max(view.select_start_time(), view.select_end_time()));