mirrors/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity.git synced 2025-01-23 18:02:05 -05:00
Code Issues Projects Releases Packages Wiki Activity

Taskbar: Wait on all waitable children in SIGCHLD handler

Browse source 
We need to call waitpid until no more waitable children are available.
This is necessary because SIGCHLD signals may coalesce into one when
multiple children terminate almost simultaneously.

Also, switch to EventLoop's asynchronous signal handling mechanism,
which allows more complex operations in the signal handler.
This commit is contained in:
Tom 2020-12-01 20:20:30 -07:00 • committed by Andreas Kling
parent d6174f9c79
commit f68115aba3
2 changed files with 7 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibGUI/Application.h
View file

@ -74,6 +74,8 @@ public:
bool focus_debugging_enabled() const { return m_focus_debugging_enabled; }
Core::EventLoop& event_loop() { return *m_event_loop; }
private:
Application(int argc, char** argv);

9
Services/Taskbar/main.cpp
View file

@ -25,6 +25,7 @@
*/
#include "TaskbarWindow.h"
#include <LibCore/EventLoop.h>
#include <LibGUI/Application.h>
#include <signal.h>
#include <stdio.h>
@ -38,10 +39,10 @@ int main(int argc, char** argv)
}
auto app = GUI::Application::construct(argc, argv);
signal(SIGCHLD, [](int signo) {
(void)signo;
wait(nullptr);
app->event_loop().register_signal(SIGCHLD, [](int) {
// Wait all available children
while (waitpid(-1, nullptr, WNOHANG) > 0)
;
});
if (pledge("stdio shared_buffer accept proc exec rpath", nullptr) < 0) {