mirrors/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity.git synced 2025-01-23 18:02:05 -05:00
Code Issues Projects Releases Packages Wiki Activity

Ladybird: Set the sample rate on the audio device's audio format

Browse source 
For example, on https://xboygeniusx.bandcamp.com/album/the-record, a
song with a duration of 03:52 would actually complete in 03:33 on my
machine. This issue only affects Ladybird on Lagom; on Serenity, we
already take the entire 03:52 to play the song.
This commit is contained in:
Timothy Flynn 2023-06-22 10:01:36 -04:00 • committed by Andreas Kling
parent 2cbc9a6642
commit f6e10ecbfd
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
Ladybird/AudioCodecPluginLadybird.cpp
View file

@ -84,11 +84,12 @@ private:
}; };
struct AudioDevice { struct AudioDevice {
static AudioDevice create() static AudioDevice create(Audio::Loader const& loader)
{ {
auto const& device_info = QMediaDevices::defaultAudioOutput(); auto const& device_info = QMediaDevices::defaultAudioOutput();
auto format = device_info.preferredFormat(); auto format = device_info.preferredFormat();
format.setSampleRate(static_cast<int>(loader.sample_rate()));
format.setChannelCount(2); format.setChannelCount(2);
auto audio_output = make<QAudioSink>(device_info, format); auto audio_output = make<QAudioSink>(device_info, format);
@ -129,7 +130,7 @@ private:
void run() override void run() override
{ {
auto devices = make<QMediaDevices>(); auto devices = make<QMediaDevices>();
auto audio_device = AudioDevice::create(); auto audio_device = AudioDevice::create(m_loader);
connect(devices, &QMediaDevices::audioOutputsChanged, this, [this]() { connect(devices, &QMediaDevices::audioOutputsChanged, this, [this]() {
queue_task({ AudioTask::Type::RecreateAudioDevice }).release_value_but_fixme_should_propagate_errors(); queue_task({ AudioTask::Type::RecreateAudioDevice }).release_value_but_fixme_should_propagate_errors();
@ -175,7 +176,7 @@ private:
break; break;
case AudioTask::Type::RecreateAudioDevice: case AudioTask::Type::RecreateAudioDevice:
audio_device = AudioDevice::create(); audio_device = AudioDevice::create(m_loader);
continue; continue;
} }
} }