mirrors/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity.git synced 2025-01-23 09:51:57 -05:00
Code Issues Projects Releases Packages Wiki Activity

LibJS: Support more weird date formats found on the web

Browse source
This commit is contained in:
Kyle Lanmon 2024-01-28 23:36:40 -06:00 • committed by Andreas Kling
parent 05b30ece17
commit f757a7cfa8
2 changed files with 38 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
Userland/Libraries/LibJS/Runtime/DateConstructor.cpp
View file

@ -161,14 +161,24 @@ static double parse_date_string(ByteString const& date_string)
// Both Chrome and Firefox seem to support "4/17/2019 11:08 PM +0000" with most parts
// being optional, however this is not clearly documented anywhere.
static constexpr auto extra_formats = AK::Array {
"%a %b %d %Y %T GMT%z (%+)"sv, // "Tue Nov 07 2023 10:05:55 GMT-0500 (Eastern Standard Time)"
"%a, %d %b %Y %T %Z"sv, // "Tue, 07 Nov 2023 15:05:55 GMT"
"%a %b %e %T %z %Y"sv, // "Wed Apr 17 23:08:53 +0000 2019"
"%a%t%b%t%d%t%Y%t%T%tGMT%z%t(%+)"sv, // "Tue Nov 07 2023 10:05:55 GMT-0500 (Eastern Standard Time)"
"%a,%t%d%t%b%t%Y%t%T%t%Z"sv, // "Tue, 07 Nov 2023 15:05:55 GMT"
"%a%t%b%t%e%t%T%t%z%t%Y"sv, // "Wed Apr 17 23:08:53 +0000 2019"
"%m/%e/%Y"sv, // "4/17/2019"
"%m/%e/%Y %R %z"sv, // "12/05/2022 10:00 -0800"
"%Y/%m/%e %R"sv, // "2014/11/14 13:05"
"%Y-%m-%e %R"sv, // "2014-11-14 13:05"
"%B %e, %Y %T"sv, // "June 5, 2023 17:00:00"
"%m/%e/%Y%t%R%t%z"sv, // "12/05/2022 10:00 -0800"
"%Y/%m/%e%t%R"sv, // "2014/11/14 13:05"
"%Y-%m-%e%t%R"sv, // "2014-11-14 13:05"
"%B%t%e,%t%Y%t%T"sv, // "June 5, 2023 17:00:00"
"%b%t%d%t%Y%t%Z"sv, // "Jan 01 1970 GMT"
"%a%t%b%t%e%t%T%t%Y%t%z"sv, // "Wed Apr 17 23:08:53 2019 +0000"
"%Y-%m-%e%t%R%z"sv, // "2021-07-01 03:00Z"
"%a,%t%e%t%b%t%Y%t%T%t%z"sv, // "Wed, 17 Jan 2024 11:36:34 +0000"
"%a%t%b%t%e%t%Y%t%T%tGMT%t%x%t(%+)"sv, // "Sun Jan 21 2024 21:11:31 GMT 0100 (Central European Standard Time)"
"%Y-%m-%e%t%T"sv, // "2024-01-15 00:00:01"
"%a%t%b%t%e%t%Y%t%T%t%Z"sv, // "Tue Nov 07 2023 10:05:55 UTC"
"%a%t%b%t%e%t%T%t%Y"sv, // "Wed Apr 17 23:08:53 2019"
"%Y-%m-%eT%T%X%z"sv, // "2024-01-26T22:10:11.306+0000"
"%m/%e/%Y,%t%T%t%p"sv, // "1/27/2024, 9:28:30 AM"
};
for (auto const& format : extra_formats) {

20
Userland/Libraries/LibJS/Tests/builtins/Date/Date.parse.js
View file

@ -14,6 +14,26 @@ test("basic functionality", () => {
expect(Date.parse("+020000-01")).toBe(568971820800000);
expect(Date.parse("+020000-01T00:00:00.000Z")).toBe(568971820800000);
const originalTimeZone = setTimeZone("UTC");
setTimeZone("America/Chicago");
expect(Date.parse("Jan 01 1970 GMT")).toBe(0);
expect(Date.parse("Wed Apr 17 23:08:53 2019 +0000")).toBe(1555542533000);
expect(Date.parse("2021-07-01 03:00Z")).toBe(1625108400000);
expect(Date.parse("2024-01-08 9:00Z")).toBe(1704704400000);
expect(Date.parse("Wed, 17 Jan 2024 11:36:34 +0000")).toBe(1705491394000);
expect(Date.parse("Sun Jan 21 2024 21:11:31 GMT 0100 (Central European Standard Time)")).toBe(
1705867891000
);
expect(Date.parse("2024-01-15 00:00:01")).toBe(1705298401000);
expect(Date.parse("Tue Nov 07 2023 10:05:55 UTC")).toBe(1699351555000);
expect(Date.parse("Wed Apr 17 23:08:53 2019")).toBe(1555560533000);
expect(Date.parse("2024-01-26T22:10:11.306+0000")).toBe(1706307011000); // FIXME: support sub-second precision
expect(Date.parse("1/27/2024, 9:28:30 AM")).toBe(1706369310000);
// FIXME: Create a scoped time zone helper when bytecode supports the `using` declaration.
setTimeZone(originalTimeZone);
expect(Date.parse(2020)).toBe(1577836800000);
expect(Date.parse("+1980")).toBe(NaN);