mirrors/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity.git synced 2025-01-23 09:51:57 -05:00
Code Issues Projects Releases Packages Wiki Activity

LibVideo/VP9: Return error for frames with invalid subsampling format

Browse source 
Previously, the program would crash if this condition was encountered.
We now return a decoder error allowing for graceful failure.
This commit is contained in:
Tim Ledbetter 2023-10-10 17:45:00 +01:00 • committed by Sam Atkins
parent 409eb644c8
commit fd3837c63b
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibVideo/VP9/Parser.cpp
View file

@ -355,7 +355,7 @@ DecoderErrorOr<ColorConfig> Parser::parse_color_config(BigEndianInputBitStream&
return DecoderError::corrupted("color_config: RGB reserved zero was set"sv); return DecoderError::corrupted("color_config: RGB reserved zero was set"sv);
} else { } else {
// FIXME: Spec does not specify the subsampling value here. Is this an error or should we set a default? // FIXME: Spec does not specify the subsampling value here. Is this an error or should we set a default?
VERIFY_NOT_REACHED(); return DecoderError::corrupted("color_config: Invalid subsampling value for profile 0 or 2"sv);
} }
} }