mirrors/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity.git synced 2025-01-26 03:12:07 -05:00
Code Issues Projects Releases Packages Wiki Activity
4024 commits 1 branch 0 tags 514 MiB
Commit graph

28 commits

Author SHA1 Message Date
Andreas Kling
cfe09784a4 TextEditor: Clear the dirty flag in newly opened documents 2019-08-29 18:54:06 +02:00
Andreas Kling
72950f93a3 TextEditor: Move the Font menu inside the View menu 
This will be our first user of the nested menus feature. :^)
 2019-08-29 06:36:35 +02:00
Andreas Kling
b1763238d7 TextEditor: Ask the user before closing a dirty (modified) document 
It's a little unfortunate that we have two separate code paths that can
lead to asking the user about this. Longer-term we should find a way to
unify these things.

Fixes #491.
 2019-08-27 20:39:01 +02:00
Andreas Kling
ecbedda34c TextEditor: Add a "document dirty" flag and show it in the window title 
This lets you know if the document has been modified since last save.
 2019-08-27 20:18:19 +02:00
Andreas Kling
07933d0b46 TextEditor: Let's enable line wrapping by default 2019-08-27 17:05:01 +02:00
Andreas Kling
b6de723eb3 TextEditor: Move line wrapping setting to a new "View" menu 2019-08-27 17:01:52 +02:00
Andreas Kling
cef2c04952 TextEditor: Move all "File" menu entries into the app menu instead 
It felt weird to have both the app menu *and* a "File" menu.
 2019-08-26 17:59:05 +02:00
Andreas Kling
d5f3487203 TextEditor: Select everything in the find textbox when pressing Ctrl+F 
This allows you to press Ctrl+F and immediately start typing a new
search string, instead of having to remove the old one first. :^)
 2019-08-25 21:46:39 +02:00
Andreas Kling
e8e8741c88 LibGUI+TextEditor: Make GButton activate its action if present 
Previously even if you assigned a GAction to a GButton, you still had
to activate() the action manually by hooking the GButton::on_click
callback.
 2019-08-25 21:46:39 +02:00
Andreas Kling
ded005500d TextEditor: Add actions for find next/previous (Ctrl+G, Ctrl+Shift+G) 2019-08-25 21:46:39 +02:00
Andreas Kling
d88c40568f TextEditor: Add search-related actions to the text editor context menu 
Using the new GTextEditor::add_custom_context_menu_action() mechanism.

Fixes #478.
 2019-08-25 21:46:28 +02:00
Andreas Kling
97a695403b TextEditor: Add a menu action for turning line-wrapping on/off 2019-08-25 12:23:34 +02:00
Andrew Weller
e75e33eb46 TextEditor: Replaced 'Find' button with 'Prev' and 'Next' buttons. 2019-08-24 21:57:42 +02:00
Andreas Kling
b1bc7a1b5d TextEditor: Don't try to load contents of files we didn't even open 
If the CFile::open() call fails, we shouldn't continue with trying to
load the file.
 2019-08-23 19:11:56 +02:00
Andreas Kling
d56786ccd8 TextEditor: Avoid an unnecessary whole-file copy when opening something 
This was left over from before we had the StringView(const ByteBuffer&)
constructor to help us.
 2019-08-23 19:05:34 +02:00
Andreas Kling
fae379b1f0 TextEditor: Search box should find on return, close itself on escape 
This patch adds basic keyboard access to the search box. We also yield
focus back gracefully to the text document when the search box is no
longer wanted.

Focus should probably move automatically when an ancestor of the
currently focused widget if made invisible..
 2019-08-22 11:11:48 +02:00
Andreas Kling
96c5c9ce12 TextEditor: Hide the search bar until the user asks for it 
You can get to it via Edit/Find, or by pressing Ctrl+F.
 2019-08-22 11:02:03 +02:00
Andreas Kling
bb74832dd6 TextEditor: Add a search bar that allows you to search for text 
If the text is not found, we show a friendly message box that says we
didn't find the text! :^)
 2019-08-21 21:30:20 +02:00
rhin123
a175e76948 TextEditor: Include extension during SaveAs 
When we save-as in the text editor we now auto-populate GFilePicker /w
the current name & extension.
 2019-07-29 20:46:31 +02:00
Andreas Kling
b98c77229d TextEditor: Let's have line numbers starting at 1. 
Thanks to Dan for pointing this out on IRC:

<danboid> I see TextEditor still numbers its lines from 0. You're too much of a programmer sometimes kling! :)
<  kling> that might be the most extreme form of "programmer design" I've seen in serenity
 2019-07-27 21:20:38 +02:00
Andreas Kling
eda272eec8 TextEditor: Add back lost "Save as..." action. 2019-07-27 20:32:19 +02:00
Rhin
d6cd98cfa1 TextEditor: Fix nullptr refrence to save action & m_path (#364) 
We forgot to persist our actions in the constructor for later reference, whoops.
Also use the correct path in the "open" action.
 2019-07-26 06:48:39 +02:00
Andreas Kling
442256b5f8 TextEditor: Add "Save as..." action. 
Add a basic "save as" action to the TextEditor app, and make "save" fall
back to using "save as" if there's no name already set.

Fixes #282.
 2019-07-24 06:32:30 +02:00
Andreas Kling
a17fbd98e7 LibGUI: Add input types to GMessageBox. 
Currently the two available input types are:

- GMessageBox::InputType::OK (default)
- GMessageBox::InputType::OKCancel

Based on your choice, GMessageBox::exec() will return ExecOK or ExecCancel.
 2019-07-16 21:41:13 +02:00
rhin123
1f77fbb75c TextEditorWidget: Stop dbgprintf from printing null 2019-07-16 08:34:51 +02:00
rhin123
82d9410226 TextEditorWidget: Added improved save feature. 
Instead of saving to a temp file, the TextEditorWidget now saves
to a path returned by the improved GFilePicker.
 2019-07-15 18:33:33 +02:00
Andreas Kling
d0a2668833 TextEditor: Fix build (copy_ref() in outdated PR changes.) 2019-07-11 21:30:49 +02:00
Rhin
d7b836858e TextEditor: Move the application UI into a dedicated TextEditorWidget. (#292) 
Added a main widget for the text editor as a stepping stone to add new features.
 2019-07-11 20:52:33 +02:00