mirror of
https://github.com/SerenityOS/serenity.git
synced 2025-01-23 18:02:05 -05:00
07341c3594
Previously accept() would copy the listener socket's cloexec and non-blocking flag. With that fixed however TCPServer and LocalServer now leak file descriptors into child processes and are blocking.
163 lines
3.8 KiB
C++
163 lines
3.8 KiB
C++
/*
|
|
* Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#include <LibCore/LocalServer.h>
|
|
#include <LibCore/LocalSocket.h>
|
|
#include <LibCore/Notifier.h>
|
|
#include <fcntl.h>
|
|
#include <stdio.h>
|
|
#include <sys/socket.h>
|
|
#include <sys/stat.h>
|
|
#include <unistd.h>
|
|
|
|
#ifndef SOCK_NONBLOCK
|
|
# include <sys/ioctl.h>
|
|
#endif
|
|
|
|
namespace Core {
|
|
|
|
LocalServer::LocalServer(Object* parent)
|
|
: Object(parent)
|
|
{
|
|
}
|
|
|
|
LocalServer::~LocalServer()
|
|
{
|
|
if (m_fd >= 0)
|
|
::close(m_fd);
|
|
}
|
|
|
|
bool LocalServer::take_over_from_system_server(String const& socket_path)
|
|
{
|
|
if (m_listening)
|
|
return false;
|
|
|
|
if (!LocalSocket::s_overtaken_sockets_parsed)
|
|
LocalSocket::parse_sockets_from_system_server();
|
|
|
|
int fd = -1;
|
|
if (socket_path.is_null()) {
|
|
// We want the first (and only) socket.
|
|
if (LocalSocket::s_overtaken_sockets.size() == 1) {
|
|
fd = LocalSocket::s_overtaken_sockets.begin()->value;
|
|
}
|
|
} else {
|
|
auto it = LocalSocket::s_overtaken_sockets.find(socket_path);
|
|
if (it != LocalSocket::s_overtaken_sockets.end()) {
|
|
fd = it->value;
|
|
}
|
|
}
|
|
|
|
if (fd >= 0) {
|
|
// Sanity check: it has to be a socket.
|
|
struct stat stat;
|
|
int rc = fstat(fd, &stat);
|
|
if (rc == 0 && S_ISSOCK(stat.st_mode)) {
|
|
// The SystemServer has passed us the socket, so use that instead of
|
|
// creating our own.
|
|
m_fd = fd;
|
|
// It had to be !CLOEXEC for obvious reasons, but we
|
|
// don't need it to be !CLOEXEC anymore, so set the
|
|
// CLOEXEC flag now.
|
|
fcntl(m_fd, F_SETFD, FD_CLOEXEC);
|
|
|
|
m_listening = true;
|
|
setup_notifier();
|
|
return true;
|
|
} else {
|
|
if (rc != 0)
|
|
perror("fstat");
|
|
dbgln("It's not a socket, what the heck??");
|
|
}
|
|
}
|
|
|
|
dbgln("Failed to take the socket over from SystemServer");
|
|
|
|
return false;
|
|
}
|
|
|
|
void LocalServer::setup_notifier()
|
|
{
|
|
m_notifier = Notifier::construct(m_fd, Notifier::Event::Read, this);
|
|
m_notifier->on_ready_to_read = [this] {
|
|
if (on_ready_to_accept)
|
|
on_ready_to_accept();
|
|
};
|
|
}
|
|
|
|
bool LocalServer::listen(const String& address)
|
|
{
|
|
if (m_listening)
|
|
return false;
|
|
|
|
int rc;
|
|
|
|
#ifdef SOCK_NONBLOCK
|
|
m_fd = socket(AF_LOCAL, SOCK_STREAM | SOCK_NONBLOCK | SOCK_CLOEXEC, 0);
|
|
#else
|
|
m_fd = socket(AF_LOCAL, SOCK_STREAM, 0);
|
|
int option = 1;
|
|
ioctl(m_fd, FIONBIO, &option);
|
|
fcntl(m_fd, F_SETFD, FD_CLOEXEC);
|
|
#endif
|
|
VERIFY(m_fd >= 0);
|
|
#ifndef __APPLE__
|
|
rc = fchmod(m_fd, 0600);
|
|
if (rc < 0) {
|
|
perror("fchmod");
|
|
VERIFY_NOT_REACHED();
|
|
}
|
|
#endif
|
|
|
|
auto socket_address = SocketAddress::local(address);
|
|
auto un_optional = socket_address.to_sockaddr_un();
|
|
if (!un_optional.has_value()) {
|
|
perror("bind");
|
|
return false;
|
|
}
|
|
auto un = un_optional.value();
|
|
rc = ::bind(m_fd, (const sockaddr*)&un, sizeof(un));
|
|
if (rc < 0) {
|
|
perror("bind");
|
|
return false;
|
|
}
|
|
|
|
rc = ::listen(m_fd, 5);
|
|
if (rc < 0) {
|
|
perror("listen");
|
|
return false;
|
|
}
|
|
|
|
m_listening = true;
|
|
setup_notifier();
|
|
return true;
|
|
}
|
|
|
|
RefPtr<LocalSocket> LocalServer::accept()
|
|
{
|
|
VERIFY(m_listening);
|
|
sockaddr_un un;
|
|
socklen_t un_size = sizeof(un);
|
|
#ifndef AK_OS_MACOS
|
|
int accepted_fd = ::accept4(m_fd, (sockaddr*)&un, &un_size, SOCK_NONBLOCK | SOCK_CLOEXEC);
|
|
#else
|
|
int accepted_fd = ::accept(m_fd, (sockaddr*)&un, &un_size);
|
|
#endif
|
|
if (accepted_fd < 0) {
|
|
perror("accept");
|
|
return nullptr;
|
|
}
|
|
|
|
#ifdef AK_OS_MACOS
|
|
int option = 1;
|
|
ioctl(m_fd, FIONBIO, &option);
|
|
(void)fcntl(accepted_fd, F_SETFD, FD_CLOEXEC);
|
|
#endif
|
|
|
|
return LocalSocket::construct(accepted_fd);
|
|
}
|
|
|
|
}
|