mirrors/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity.git synced 2025-01-26 19:32:06 -05:00
Code Issues Projects Releases Packages Wiki Activity
serenity/Kernel
History
Daniel Bertalan fa8507d1ce Kernel: Fix UB caused by taking a reference to a packed struct's member 
Taking a reference or a pointer to a value that's not aligned properly
is undefined behavior. While `[[gnu::packed]]` ensures that reads from
and writes to fields of packed structs is a safe operation, the
information about the reduced alignment is lost when creating pointers
to these values.

Weirdly enough, GCC's undefined behavior sanitizer doesn't flag these,
even though the doc of `-Waddress-of-packed-member` says that it usually
leads to UB. In contrast, x86_64 Clang does flag these, which renders
the 64-bit kernel unable to boot.

For now, the `address-of-packed-member` warning will only be enabled in
the kernel, as it is absolutely crucial there because of KUBSAN, but
might get excessively noisy for the userland in the future.

Also note that we can't append to `CMAKE_CXX_FLAGS` like we do for other
flags in the kernel, because flags added via `add_compile_options` come
after these, so the `-Wno-address-of-packed-member` in the root would
cancel it out.
2021-08-08 10:55:36 +02:00
..
ACPI Kernel: Move Mutex into Locking/ 2021-08-07 11:48:00 +02:00
API Kernel: Disable big process lock for sys$sync 2021-08-07 15:30:26 +02:00
Arch Kernel: Rename Process::space() => Process::address_space() 2021-08-06 14:05:58 +02:00
Bus Kernel: Move SpinLock.h into Locking/ 2021-08-07 11:48:00 +02:00
Devices Everywhere: Replace AK::Singleton => Singleton 2021-08-08 00:03:45 +02:00
FileSystem Kernel: Port BlockBasedFileSystem to ProtectedValue :^) 2021-08-08 00:28:10 +02:00
Graphics Everywhere: Replace AK::Singleton => Singleton 2021-08-08 00:03:45 +02:00
Heap Kernel: Bump eternal kmalloc range to 4 MiB 2021-08-08 10:55:36 +02:00
Interrupts Everywhere: Replace AK::Singleton => Singleton 2021-08-08 00:03:45 +02:00
Locking Kernel: Introduce ProtectedValue 2021-08-07 11:48:00 +02:00
Memory Kernel: Fix UB caused by taking a reference to a packed struct's member 2021-08-08 10:55:36 +02:00
Modules
Net Everywhere: Replace AK::Singleton => Singleton 2021-08-08 00:03:45 +02:00
Prekernel Meta: Add Clang support to the CMake build scripts 2021-08-08 10:55:36 +02:00
Storage Kernel: Remove unused mutex PATADiskDevice::m_lock 2021-08-08 00:08:24 +02:00
Syscalls Everywhere: Replace AK::Singleton => Singleton 2021-08-08 00:03:45 +02:00
Tasks
Time Everywhere: Replace AK::Singleton => Singleton 2021-08-08 00:03:45 +02:00
TTY Kernel: Remove unnecessary churn in ConsoleManagement 2021-08-08 00:44:25 +02:00
VirtIO Kernel: Move SpinLock.h into Locking/ 2021-08-07 11:48:00 +02:00
AddressSanitizer.cpp
AddressSanitizer.h
Assertions.h AK+Kernel: Print TODO when a TODO() is executed 2021-08-04 11:01:16 +02:00
AtomicEdgeAction.h
BootInfo.h
CMakeLists.txt Kernel: Fix UB caused by taking a reference to a packed struct's member 2021-08-08 10:55:36 +02:00
CMOS.cpp
CMOS.h
CommandLine.cpp
CommandLine.h
ConsoleDevice.cpp Everywhere: Replace AK::Singleton => Singleton 2021-08-08 00:03:45 +02:00
ConsoleDevice.h
CoreDump.cpp Kernel: Move SpinLock.h into Locking/ 2021-08-07 11:48:00 +02:00
CoreDump.h
Debug.h.in Kernel: Implement a ISO 9660 filesystem reader :^) 2021-08-07 15:21:58 +02:00
DoubleBuffer.cpp Kernel: Add convenience values to the Memory::Region::Access enum 2021-08-06 22:25:00 +02:00
DoubleBuffer.h Kernel: Move Mutex into Locking/ 2021-08-07 11:48:00 +02:00
embedmap.sh
Forward.h Kernel: Rename Memory::Space => Memory::AddressSpace 2021-08-06 14:05:58 +02:00
FutexQueue.cpp
FutexQueue.h Kernel: Move SpinLock.h into Locking/ 2021-08-07 11:48:00 +02:00
GlobalProcessExposed.cpp Kernel: Migrate ARP table locking to ProtectedValue 2021-08-07 11:48:00 +02:00
init.cpp Kernel: Fix deprecated array comparison 2021-08-08 10:55:36 +02:00
IO.h
KBuffer.h Kernel: Add convenience values to the Memory::Region::Access enum 2021-08-06 22:25:00 +02:00
KBufferBuilder.cpp Kernel: Add convenience values to the Memory::Region::Access enum 2021-08-06 22:25:00 +02:00
KBufferBuilder.h
KLexicalPath.cpp
KLexicalPath.h
kprintf.cpp Kernel: Move SpinLock.h into Locking/ 2021-08-07 11:48:00 +02:00
KResult.h
kstdio.h
KString.cpp
KString.h
KSyms.cpp Kernel: Print panic backtrace to both the screen and serial 2021-08-04 20:14:54 +02:00
KSyms.h Kernel: Print panic backtrace to both the screen and serial 2021-08-04 20:14:54 +02:00
linker.ld
MiniStdLib.cpp
mkmap.sh
Module.h
Multiboot.h
Panic.cpp Kernel: Print panic backtrace to both the screen and serial 2021-08-04 20:14:54 +02:00
Panic.h
PerformanceEventBuffer.cpp Kernel: Add convenience values to the Memory::Region::Access enum 2021-08-06 22:25:00 +02:00
PerformanceEventBuffer.h
PerformanceManager.h Kernel: Rename Range => VirtualRange 2021-08-06 14:05:58 +02:00
PhysicalAddress.h
Process.cpp Everywhere: Replace AK::Singleton => Singleton 2021-08-08 00:03:45 +02:00
Process.h Kernel: Port process thread lists to SpinLockProtectedValue 2021-08-07 13:46:16 +02:00
ProcessExposed.cpp
ProcessExposed.h
ProcessGroup.cpp Everywhere: Replace AK::Singleton => Singleton 2021-08-08 00:03:45 +02:00
ProcessGroup.h Kernel: Port process groups to SpinLockProtectedValue 2021-08-07 13:30:59 +02:00
ProcessSpecificExposed.cpp Kernel: Rename Process::space() => Process::address_space() 2021-08-06 14:05:58 +02:00
Random.cpp Everywhere: Replace AK::Singleton => Singleton 2021-08-08 00:03:45 +02:00
Random.h Kernel: Move Lockable into its own header 2021-08-07 11:48:00 +02:00
RTC.cpp Kernel: Ensure we read valid values from the RTC CMOS registers 2021-08-04 19:53:04 +02:00
RTC.h Kernel: Ensure we read valid values from the RTC CMOS registers 2021-08-04 19:53:04 +02:00
SanCov.cpp
Scheduler.cpp Kernel: Move Kernel/Memory/ code into Kernel::Memory namespace 2021-08-06 14:05:58 +02:00
Scheduler.h Kernel: Move SpinLock.h into Locking/ 2021-08-07 11:48:00 +02:00
Sections.h
StdLib.cpp Kernel: Move Kernel/Memory/ code into Kernel::Memory namespace 2021-08-06 14:05:58 +02:00
StdLib.h
Syscall.cpp Kernel: Rename Process::space() => Process::address_space() 2021-08-06 14:05:58 +02:00
Thread.cpp Kernel: Fix UB caused by taking a reference to a packed struct's member 2021-08-08 10:55:36 +02:00
Thread.h Kernel: Port process thread lists to SpinLockProtectedValue 2021-08-07 13:46:16 +02:00
ThreadBlockers.cpp Kernel: Make AsyncDeviceRequest::name() return StringView 2021-08-06 00:37:47 +02:00
ThreadTracer.cpp
ThreadTracer.h
TimerQueue.cpp Everywhere: Replace AK::Singleton => Singleton 2021-08-08 00:03:45 +02:00
TimerQueue.h Kernel: Do not cancel stale timers when servicing sys$alarm 2021-08-03 18:44:01 +02:00
UBSanitizer.cpp
UnixTypes.h
UserOrKernelBuffer.cpp Kernel: Move Kernel/Memory/ code into Kernel::Memory namespace 2021-08-06 14:05:58 +02:00
UserOrKernelBuffer.h Kernel: Move Kernel/Memory/ code into Kernel::Memory namespace 2021-08-06 14:05:58 +02:00
VirtualAddress.h
WaitQueue.cpp
WaitQueue.h Kernel: Move SpinLock.h into Locking/ 2021-08-07 11:48:00 +02:00
WorkQueue.cpp Kernel: Move SpinLock.h into Locking/ 2021-08-07 11:48:00 +02:00
WorkQueue.h