mirrors/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity.git synced 2025-01-24 02:12:09 -05:00
Code Issues Projects Releases Packages Wiki Activity
serenity/Kernel
History
Ben Wiederhake c05c5a7ff4 Kernel: Clarify ambiguous {File,Description}::absolute_path 
Found due to smelly code in InodeFile::absolute_path.

In particular, this replaces the following misleading methods:

File::absolute_path
This method *never* returns an actual path, and if called on an
InodeFile (which is impossible), it would VERIFY_NOT_REACHED().

OpenFileDescription::try_serialize_absolute_path
OpenFileDescription::absolute_path
These methods do not guarantee to return an actual path (just like the
other method), and just like Custody::absolute_path they do not
guarantee accuracy. In particular, just renaming the method made a
TOCTOU bug obvious.

The new method signatures use KResultOr, just like
try_serialize_absolute_path() already did.
2021-10-31 12:06:28 +01:00
..
API LibC: Include sys/uio.h in sys/socket.h for struct iovec 2021-10-28 11:24:36 +02:00
Arch Kernel: Call try_set_coredump_property with StringView arguments 2021-10-21 22:19:50 +02:00
Bus Kernel/PCI: Remove InterruptDisabler usage 2021-10-23 19:17:44 +02:00
Devices Kernel: Clarify ambiguous {File,Description}::absolute_path 2021-10-31 12:06:28 +01:00
FileSystem Kernel: Clarify ambiguous {File,Description}::absolute_path 2021-10-31 12:06:28 +01:00
Firmware Kernel/SysFS: Provide a way to "truncate" and "set" mtime on inodes 2021-10-09 12:07:56 +02:00
Graphics Kernel + WindowServer: Re-define the interface to framebuffer devices 2021-10-27 07:57:44 +03:00
Heap Kernel: Use a larger kmalloc chunk size on 64-bit platforms 2021-10-26 10:38:35 +02:00
Interrupts Kernel: Add cross platform RegisterState header and Aarch64 version 2021-10-15 21:48:45 +01:00
Library Kernel: Split ScopedCritical so header is platform independent 2021-10-15 21:48:45 +01:00
Locking Kernel: Move spinlock into Arch 2021-10-15 21:48:45 +01:00
Memory Kernel: Take VMObject lock once in Region::remap_vmobject_page() 2021-10-26 09:03:41 +02:00
Net Kernel: Clarify ambiguous {File,Description}::absolute_path 2021-10-31 12:06:28 +01:00
Prekernel Toolchain+Meta: Update LLVM version to 13.0.0 2021-10-17 17:09:58 +01:00
Storage Kernel: Declare copy-ability of IOAddressGroup 2021-10-10 21:03:27 +01:00
Syscalls Kernel: Clarify ambiguous {File,Description}::absolute_path 2021-10-31 12:06:28 +01:00
Tasks Kernel: Store process names as KString 2021-09-07 13:53:14 +02:00
Time Kernel: Add TimeManagement::is_initialized() 2021-10-26 01:00:54 +02:00
TTY Kernel: Clarify ambiguous {File,Description}::absolute_path 2021-10-31 12:06:28 +01:00
AddressSanitizer.cpp
AddressSanitizer.h
Assertions.h
AtomicEdgeAction.h Kernel: Add per platform Processor.h headers 2021-10-14 01:23:08 +01:00
BootInfo.h
CMakeLists.txt Kernel + WindowServer: Re-define the interface to framebuffer devices 2021-10-27 07:57:44 +03:00
CMOS.cpp Kernel: Move x86 IO instructions code into the x86 specific folder 2021-10-01 12:27:20 +02:00
CMOS.h
CommandLine.cpp Kernel: Avoid allocation when checking for vmmouse 2021-10-25 23:38:28 +02:00
CommandLine.h Kernel+SystemServer: Change bootmode to system_mode 2021-10-25 23:38:28 +02:00
Coredump.cpp Kernel: Exclude userspace heap memory from coredumps by default 2021-09-30 17:54:32 +02:00
Coredump.h Kernel: Exclude userspace heap memory from coredumps by default 2021-09-30 17:54:32 +02:00
Debug.h.in Kernel: Disable lock rank enforcement by default for now 2021-09-14 18:31:16 +00:00
DoubleBuffer.cpp Kernel: Remove KBuffer::is_null() and bogus call sites :^) 2021-09-07 16:00:39 +02:00
DoubleBuffer.h Kernel: Make DoubleBuffer::try() return KResultOr 2021-09-07 13:53:14 +02:00
embedmap.sh
Forward.h Kernel: Rename DevFS => DevTmpFS 2021-09-08 00:42:20 +02:00
FutexQueue.cpp
FutexQueue.h
GlobalProcessExposed.cpp Kernel: Clarify ambiguous {File,Description}::absolute_path 2021-10-31 12:06:28 +01:00
init.cpp Everywhere: Make some symbols __attribute__((used)) for LTO 2021-10-17 17:09:58 +01:00
KBuffer.h Kernel: Add KBuffer::bytes() and use it 2021-09-08 20:16:00 +02:00
KBufferBuilder.cpp AK+Kernel: Avoid unescaped control chars in append_escaped_for_json() 2021-09-13 14:38:53 +04:30
KBufferBuilder.h Kernel: Add KBuffer::bytes() and use it 2021-09-08 20:16:00 +02:00
KLexicalPath.cpp Kernel: Make KString factories return KResultOr + use TRY() everywhere 2021-09-06 19:25:36 +02:00
KLexicalPath.h Kernel: Make KString factories return KResultOr + use TRY() everywhere 2021-09-06 19:25:36 +02:00
kprintf.cpp Kernel: Move x86 IO instructions code into the x86 specific folder 2021-10-01 12:27:20 +02:00
kstdio.h Kernel: Add kernelearlyputstr and use it in dbgln in very-early boot 2021-09-10 22:58:08 +03:00
KString.cpp Kernel: Make KString factories return KResultOr + use TRY() everywhere 2021-09-06 19:25:36 +02:00
KString.h Kernel: Fix common misuse of KString in debug messages 2021-10-30 17:35:18 +02:00
KSyms.cpp Kernel: Split SmapDisabler so header is platform independent 2021-10-15 21:48:45 +01:00
KSyms.h
linker.ld Kernel: Support split data sections 2021-10-17 17:09:58 +01:00
MiniStdLib.cpp Kernel: Build MiniStdLib.cpp in aarch64 builds 2021-09-07 20:15:15 +01:00
mkmap.sh
Multiboot.h
Panic.cpp Kernel: Separate panic behavior from bootmode 2021-10-25 23:38:28 +02:00
Panic.h
PerformanceEventBuffer.cpp Kernel: Add cross platform RegisterState header and Aarch64 version 2021-10-15 21:48:45 +01:00
PerformanceEventBuffer.h Kernel: Accept RegisterState in append_with_ip_and_bp 2021-10-12 10:49:56 -07:00
PerformanceManager.h Kernel: Pass RegisterState by ref to event buffer 2021-10-12 10:49:56 -07:00
PhysicalAddress.h Kernel: Fix restrictions in is_allowed_to_mmap_to_userspace function 2021-10-22 13:13:00 +02:00
Process.cpp Kernel: Avoid OpenFileDescription::absolute_path 2021-10-31 12:06:28 +01:00
Process.h Kernel: Convert Formatter<Process> to use Formatter<FormatString> 2021-10-21 22:19:50 +02:00
ProcessExposed.cpp Kernel/ProcFS: Provide a way to write to ProcFS inodes 2021-10-17 14:46:59 +02:00
ProcessExposed.h Kernel/ProcFS: Provide a way to write to ProcFS inodes 2021-10-17 14:46:59 +02:00
ProcessGroup.cpp Kernel: Use KResultOr better in ProcessGroup construction 2021-09-06 01:55:27 +02:00
ProcessGroup.h AK+Everywhere: Reduce the number of template parameters of IntrusiveList 2021-09-10 18:05:46 +03:00
ProcessProcFSTraits.cpp Kernel: Rename FileDescription => OpenFileDescription 2021-09-07 13:53:14 +02:00
ProcessSpecificExposed.cpp Kernel: Clarify ambiguous {File,Description}::absolute_path 2021-10-31 12:06:28 +01:00
Random.cpp Kernel: Add per platform Processor.h headers 2021-10-14 01:23:08 +01:00
Random.h Everywhere: Make ByteBuffer::{create_*,copy}() OOM-safe 2021-09-06 01:53:26 +02:00
RTC.cpp Kernel: Move x86 IO instructions code into the x86 specific folder 2021-10-01 12:27:20 +02:00
RTC.h
SanCov.cpp Kernel/KCOV: Bring closer to typical SerenityOS coding style 2021-09-06 01:55:27 +02:00
Scheduler.cpp AK+Everywhere: Reduce the number of template parameters of IntrusiveList 2021-09-10 18:05:46 +03:00
Scheduler.h
Sections.h
StdLib.cpp Kernel: Introduce workaround to make LTO builds work with Clang 2021-10-17 17:09:58 +01:00
StdLib.h Kernel: Remove redundant [[nodiscard]] on KResult return values 2021-09-07 01:18:02 +02:00
Syscall.cpp Kernel: Fix -Wunreachable-code warnings from clang 2021-10-08 23:33:46 +02:00
Thread.cpp Kernel: Properly align stack for signal handlers 2021-10-24 21:54:51 +02:00
Thread.h Kernel: Remove unused includes 2021-10-14 01:23:08 +01:00
ThreadBlockers.cpp Kernel: Rename FileDescription => OpenFileDescription 2021-09-07 13:53:14 +02:00
ThreadTracer.cpp Kernel: Add cross platform RegisterState header and Aarch64 version 2021-10-15 21:48:45 +01:00
ThreadTracer.h Kernel: Use KResultOr and TRY() for ThreadTracer 2021-09-07 14:48:13 +02:00
TimerQueue.cpp Kernel: Remove a bunch of unused TimerQueue functions 2021-09-07 22:16:25 +02:00
TimerQueue.h AK+Everywhere: Reduce the number of template parameters of IntrusiveList 2021-09-10 18:05:46 +03:00
UBSanitizer.cpp Kernel: Add per platform Processor.h headers 2021-10-14 01:23:08 +01:00
UnixTypes.h
UserOrKernelBuffer.cpp Kernel: Make UserOrKernelBuffer return KResult from read/write/memset 2021-09-07 13:53:14 +02:00
UserOrKernelBuffer.h Kernel: Make UserOrKernelBuffer return KResult from read/write/memset 2021-09-07 13:53:14 +02:00
VirtualAddress.h
WaitQueue.cpp
WaitQueue.h
WorkQueue.cpp Kernel: Use SpinlockProtected<T> in WorkQueue 2021-10-26 10:44:10 +02:00
WorkQueue.h Kernel: Make WorkQueue::WorkItem slab allocated 2021-10-26 10:50:44 +02:00