mirrors/vanilla
1
0
Fork 0
mirror of https://github.com/vanilla-wiiu/vanilla.git synced 2025-01-22 16:21:48 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix some leaks in pipe/linux/wpa.c, discovered by clang-analyzer (#91)

Browse source
This commit is contained in:
Daniel Foster 2024-11-03 02:20:19 +10:00 committed by GitHub
parent be1b46eb9e
commit e62c607cfb
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
pipe/linux/wpa.c
View file

@ -111,6 +111,7 @@ int get_binary_in_working_directory(const char *bin_name, char *buf, size_t buf_
ssize_t link_len = readlink("/proc/self/exe", path_buf, path_size); ssize_t link_len = readlink("/proc/self/exe", path_buf, path_size);
if (link_len < 0) { if (link_len < 0) {
print_info("READLINK ERROR: %i", errno); print_info("READLINK ERROR: %i", errno);
free(path_buf);
return -1; return -1;
} }
@ -329,6 +330,7 @@ void *read_stdin(void *)
} }
} }
free(line);
return NULL; return NULL;
} }
@ -430,11 +432,13 @@ int call_dhcp(const char *network_interface, pid_t *dhclient_pid)
int r = start_process(argv, dhclient_pid, NULL, &dhclient_pipe); int r = start_process(argv, dhclient_pid, NULL, &dhclient_pipe);
if (r != VANILLA_SUCCESS) { if (r != VANILLA_SUCCESS) {
print_info("FAILED TO CALL DHCLIENT"); print_info("FAILED TO CALL DHCLIENT");
free(dhclient_buf);
free(dhclient_script);
return r; return r;
} }
free(dhclient_buf); free(dhclient_buf);
if (dhclient_script) free(dhclient_script); free(dhclient_script);
if (wait_for_output(dhclient_pipe, "bound to")) { if (wait_for_output(dhclient_pipe, "bound to")) {
return VANILLA_SUCCESS; return VANILLA_SUCCESS;
@ -761,6 +765,7 @@ int create_connect_config(const char *input_config, const char *bssid)
FILE *out_file = fopen(get_wireless_connect_config_filename(), "w"); FILE *out_file = fopen(get_wireless_connect_config_filename(), "w");
if (!out_file) { if (!out_file) {
print_info("FAILED TO OPEN OUTPUT CONFIG FILE"); print_info("FAILED TO OPEN OUTPUT CONFIG FILE");
fclose(in_file);
return VANILLA_ERROR; return VANILLA_ERROR;
} }