ClassiCube/doc/style.md
UnknownShadow200 9f88700074 Android version should always be fullscreen
Also improve documentation for String_Format (Thanks Tree)
2020-11-21 14:06:14 +11:00

2.4 KiB

Guidelines

  • Code should be C89 compatible and compilable as C++.
  • Each .c file should represent a module. (see architecture.md for more details)
  • Public functions and variables should be prefixed by module to avoid name collisions. (e.g. Game_Reset)
  • Private functions should be named using pascal case. Prefixing module is optional - do it when it makes sense.
  • Private variables don't really have a consistent style.

Types

  • Explicit integer typedefs are provided in Core.h for when needed. Otherwise just use int.
  • A few common simple structs are typedef-ed, but are rarely otherwise.
  • cc_bool is an alias for 8 bit unsigned integer
  • PackedCol field order differs depending on the underlying 3D graphics API

I may not have defined the appropriate types for your compiler, so you may need to modify Core.h

Strings

Strings are one of the most troublesome aspects of C. In this software, strings consist of:

  • Pointer to 8 bit characters (unsigned code page 437 indices)
  • Number of characters currently used (length)
  • Maximum number of characters / buffer size (capacity)

Although this makes substrings / concatenating very fast, it also means STRINGS ARE NOT NULL TERMINATED (and are not in most cases).

Thus, when using or implementing a per-platform API, you must null-terminate and convert characters to native encoding. You should implement the Platform_ConvertString function and use that.

Note: Several functions will take raw char* for performance, but this is not encouraged

String arguments

String arguments are annotated to indicate storage and readonly requirements. These are:

  • const String* - String is not modified at all
  • String* - Characters in string may be modified
  • STRING_REF - Macro annotation indicating a reference is kept to characters

To make it extra clear, functions with STRING_REF arguments usually also have _UNSAFE_ as part of their name.

For example, consider the function String Substring_UNSAFE(STRING_REF const String* str, length)

The input string is not modified at all. However, the characters of the returned string points to the characters of the input string, so modifying the characters in the input string also modifies the returned string.

In general, use of const String* is preferred when possible, and STRING_REF as little as possible.